Skip to content

ref(relay): Remove cardinality limiter config from project configs#112658

Merged
Dav1dde merged 5 commits intomasterfrom
dav1d/rm-card-project-config
Apr 13, 2026
Merged

ref(relay): Remove cardinality limiter config from project configs#112658
Dav1dde merged 5 commits intomasterfrom
dav1d/rm-card-project-config

Conversation

@Dav1dde
Copy link
Copy Markdown
Member

@Dav1dde Dav1dde commented Apr 10, 2026

Removes the cardinality limiting configs from the project config.

Follow Ups:

  • Remove cardinality limiter from Relay
  • Remove cardinality limiting options from options automator
  • Remove options from Sentry

@Dav1dde Dav1dde requested review from a team as code owners April 10, 2026 11:10
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 10, 2026
Comment thread src/sentry/relay/config/__init__.py
@github-actions
Copy link
Copy Markdown
Contributor

Backend Test Failures

Failures on dcdef9d in this run:

tests/sentry/api/endpoints/test_relay_globalconfig_v3.py::test_global_configlog
[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/api/endpoints/test_relay_globalconfig_v3.py:70: in test_global_config
    assert normalized == config
E   AssertionError: assert {'aiModelCost...d', ...}, ...} == {'aiModelCost....0, ...}, ...}
E     
E     Omitting 4 identical items, use -vv to show
E     Differing items:
E     {'options': {'profiling.profile_metrics.unsampled_profiles.enabled': True, 'profiling.profile_metrics.unsampled_profil...], 'profiling.profile_metrics.unsampled_profiles.sample_rate': 1.0, 'relay.cardinality-limiter.mode': 'disabled', ...}} != {'options': {'profiling.profile_metrics.unsampled_profiles.enabled': True, 'profiling.profile_metrics.unsampled_profil...ofiling.profile_metrics.unsampled_profiles.sample_rate': 1.0, 'relay.cardinality-limiter.error-sample-rate': 0.0, ...}}
E     
E     Full diff:
E       {
E           'aiModelCosts': None,
E           'measurements': {
E               'builtinMeasurements': [
E                   {
E                       'name': 'app_start_cold',
E                       'unit': 'millisecond',
E                   },
E                   {
E                       'name': 'app_start_warm',
E                       'unit': 'millisecond',
E                   },
E                   {
E                       'name': 'cls',
E                       'unit': 'none',
E                   },
E                   {
E                       'name': 'connection.rtt',
E                       'unit': 'millisecond',
E                   },
E                   {
E                       'name': 'fcp',
E                       'unit': 'millisecond',
E                   },
E                   {
E                       'name': 'fid',
E                       'unit': 'millisecond',
E                   },
E                   {
E                       'name': 'fp',
E                       'unit': 'millisecond',
E                   },
E                   {
E                       'name': 'frames_frozen_rate',
E                       'unit': 'ratio',
E                   },
E                   {
E                       'name': 'frames_frozen',
E                       'unit': 'none',
E                   },
... (1492 more lines)

Comment thread tests/sentry/core/endpoints/test_project_details.py
Copy link
Copy Markdown
Member

@shellmayr shellmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 95c2fd4. Configure here.

Comment thread tests/sentry/relay/test_config.py
@Dav1dde Dav1dde merged commit 24704ee into master Apr 13, 2026
77 checks passed
@Dav1dde Dav1dde deleted the dav1d/rm-card-project-config branch April 13, 2026 05:53
wedamija pushed a commit that referenced this pull request Apr 13, 2026
…112658)

Removes the cardinality limiting configs from the project config.

Follow Ups:
- Remove cardinality limiter from Relay
- Remove cardinality limiting options from options automator
- Remove options from Sentry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants